refactor(claude): rename simplify skill to check
This commit is contained in:
@@ -1,20 +1,20 @@
|
|||||||
---
|
---
|
||||||
name: simplify
|
name: check
|
||||||
description: Daily-driver review of in-flight changes (or specified files) for reuse, simplification, efficiency, and high-confidence bugs. Flags code that duplicates existing helpers, overengineering, dead code, hot-path bloat, premature abstraction, real correctness issues, and unnecessary comments or tests. Default mode diffs the working tree and staged changes against the main branch. Pass paths (`/simplify src/foo.rs`) to review file state instead. Use as the fast pre-PR review pass. For a deeper whole-tree retrospective, use /audit.
|
description: Daily-driver review of in-flight changes (or specified files) for reuse, simplification, efficiency, and high-confidence bugs. Flags code that duplicates existing helpers, overengineering, dead code, hot-path bloat, premature abstraction, real correctness issues, and unnecessary comments or tests. Default mode diffs the working tree and staged changes against the main branch. Pass paths (`/check src/foo.rs`) to review file state instead. Use as the fast pre-PR review pass. For a deeper whole-tree retrospective, use /audit.
|
||||||
---
|
---
|
||||||
|
|
||||||
# /simplify
|
# /check
|
||||||
|
|
||||||
Simplification review of work-in-progress. Default runs against the current diff. Explicit paths switch to file-state review.
|
Pre-PR review pass over work-in-progress. Default runs against the current diff. Explicit paths switch to file-state review.
|
||||||
|
|
||||||
## Invocation
|
## Invocation
|
||||||
|
|
||||||
```
|
```
|
||||||
/simplify # diff working tree + staged vs main/master
|
/check # diff working tree + staged vs main/master
|
||||||
/simplify --staged # only staged changes
|
/check --staged # only staged changes
|
||||||
/simplify --branch develop # diff against a different base
|
/check --branch develop # diff against a different base
|
||||||
/simplify src/foo.rs # review one file as-is (ignores diff)
|
/check src/foo.rs # review one file as-is (ignores diff)
|
||||||
/simplify src/foo/ src/bar.rs # review multiple paths as-is
|
/check src/foo/ src/bar.rs # review multiple paths as-is
|
||||||
```
|
```
|
||||||
|
|
||||||
Paths win: if any are given, ignore the diff and review file state.
|
Paths win: if any are given, ignore the diff and review file state.
|
||||||
@@ -120,7 +120,7 @@ Fold in any project-local `CLAUDE.md` conventions on top of these.
|
|||||||
|
|
||||||
- Low-confidence speculation. "This might break under some inputs" is not a bug finding. "This could be faster in theory" is not an efficiency finding. If you cannot point at a concrete failure mode or a concrete cost, leave it out.
|
- Low-confidence speculation. "This might break under some inputs" is not a bug finding. "This could be faster in theory" is not an efficiency finding. If you cannot point at a concrete failure mode or a concrete cost, leave it out.
|
||||||
- Issues a linter or formatter already catches.
|
- Issues a linter or formatter already catches.
|
||||||
- Missing tests or coverage gaps (separate concern, not a simplification).
|
- Missing tests or coverage gaps (separate concern, out of scope here).
|
||||||
- "You could rewrite this with library X" or other broad architectural rewrites.
|
- "You could rewrite this with library X" or other broad architectural rewrites.
|
||||||
- Items already in `TODO.md` / `BACKLOG.md`.
|
- Items already in `TODO.md` / `BACKLOG.md`.
|
||||||
- Performance theatre: micro-optimizations outside hot paths.
|
- Performance theatre: micro-optimizations outside hot paths.
|
||||||
@@ -130,7 +130,7 @@ Fold in any project-local `CLAUDE.md` conventions on top of these.
|
|||||||
Single pass, all findings together. No tiered ceremony.
|
Single pass, all findings together. No tiered ceremony.
|
||||||
|
|
||||||
```
|
```
|
||||||
## Simplification pass
|
## Review pass
|
||||||
|
|
||||||
<N> findings on <scope>.
|
<N> findings on <scope>.
|
||||||
|
|
||||||
@@ -160,6 +160,6 @@ After approval:
|
|||||||
- Rewrite history. The user is preparing a PR. Do not squash or amend existing commits.
|
- Rewrite history. The user is preparing a PR. Do not squash or amend existing commits.
|
||||||
- Auto-apply changes to public API surface. Lift those into **Needs discussion**.
|
- Auto-apply changes to public API surface. Lift those into **Needs discussion**.
|
||||||
- Touch files outside the diff (diff mode) or outside the passed paths (file mode).
|
- Touch files outside the diff (diff mode) or outside the passed paths (file mode).
|
||||||
- Reference the simplify pass in commit messages ("from /simplify", "simplification cleanup"). Describe the change, not how it surfaced.
|
- Reference the check pass in commit messages ("from /check", "review cleanup"). Describe the change, not how it surfaced.
|
||||||
- Surface a "bug" or "perf" finding you are not confident about. The signal value of this skill comes from the user trusting flagged bugs are real. False alarms erode that fast.
|
- Surface a "bug" or "perf" finding you are not confident about. The signal value of this skill comes from the user trusting flagged bugs are real. False alarms erode that fast.
|
||||||
- Pad. If the diff is clean, "Nothing flagged" is the right answer.
|
- Pad. If the diff is clean, "Nothing flagged" is the right answer.
|
||||||
Reference in New Issue
Block a user