refactor(diffsplit): clarify diff side API

plugin/git.lua

@@ -183,16 +183,16 @@ local DIFF_DIRECTIONS = { "vertical", "horizontal" }
 
 vim.api.nvim_create_user_command("Gdiffsplit", function(opts)
     local fargs = opts.fargs
-    local mods = nil
+    local layout = nil
     local rev_idx = 1
     if fargs[1] == "vertical" then
-        mods = { vertical = true }
+        layout = "vertical"
         rev_idx = 2
     elseif fargs[1] == "horizontal" then
-        mods = { vertical = false }
+        layout = "horizontal"
         rev_idx = 2
     end
-    require("git.diffsplit").open({ target = fargs[rev_idx], mods = mods })
+    require("git.diffsplit").open({ other = fargs[rev_idx], layout = layout })
 end, {
     nargs = "*",
     complete = function(arg_lead, cmd_line, _)
@@ -253,21 +253,21 @@ vim.keymap.set("n", "<Plug>(git-edit)", function()
 end, { silent = true, desc = "Edit a git object" })
 
 vim.keymap.set("n", "<Plug>(git-diffsplit-vertical)", function()
-    require("git.diffsplit").open({ mods = { vertical = true } })
+    require("git.diffsplit").open({ layout = "vertical" })
 end, { silent = true, desc = "Open a diff split against index (vertical)" })
 vim.keymap.set("n", "<Plug>(git-diffsplit-horizontal)", function()
-    require("git.diffsplit").open({ mods = { vertical = false } })
+    require("git.diffsplit").open({ layout = "horizontal" })
 end, { silent = true, desc = "Open a diff split against index (horizontal)" })
 vim.keymap.set("n", "<Plug>(git-diffsplit-vertical-head)", function()
     require("git.diffsplit").open({
-        target = "HEAD",
-        mods = { vertical = true },
+        other = "HEAD",
+        layout = "vertical",
     })
 end, { silent = true, desc = "Open a diff split against HEAD (vertical)" })
 vim.keymap.set("n", "<Plug>(git-diffsplit-horizontal-head)", function()
     require("git.diffsplit").open({
-        target = "HEAD",
-        mods = { vertical = false },
+        other = "HEAD",
+        layout = "horizontal",
     })
 end, { silent = true, desc = "Open a diff split against HEAD (horizontal)" })